Deprecate nadp module#243
Merged
thodson-usgs merged 1 commit intoDOI-USGS:mainfrom May 1, 2026
Merged
Conversation
Each public function in `dataretrieval.nadp` (`get_annual_MDN_map`, `get_annual_NTN_map`, `get_zip`) now emits a `DeprecationWarning` on call, pointing users to retrieve NADP data directly from https://nadp.slh.wisc.edu/. NADP is not a USGS service, and the module has been lightly maintained (with several long-standing TODOs that were never picked up); keeping it in `dataretrieval` is out of scope for a USGS water-data package. The module is scheduled for removal on or after 2026-11-01 (six months after this deprecation lands), tracked in the linked issue. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
thodson-usgs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeprecationWarningto every public function indataretrieval.nadp(get_annual_MDN_map,get_annual_NTN_map,get_zip).Tracking issue with full justification and timeline: #244.
Test plan
python3 -c "import dataretrieval.nadp; ..."confirms each of the three public functions raisesDeprecationWarningwith the expected message.tests/nadp_test.pyshould continue to pass (warnings are emitted but not errors); CI to confirm.🤖 Generated with Claude Code